Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCI ObjectStore #1774

Merged
merged 35 commits into from
Dec 13, 2022
Merged

Add OCI ObjectStore #1774

merged 35 commits into from
Dec 13, 2022

Conversation

eracah
Copy link
Contributor

@eracah eracah commented Dec 2, 2022 •
edited
Loading

What does this PR do?

adds an OCIObjectStore backend
ran manual tests for checkpointing and added unit tests

What issue(s) does this change relate to?

fixes CO-1297

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eracah eracah marked this pull request as ready for review December 9, 2022 01:00
@eracah eracah requested review from dakinggg and a team as code owners December 9, 2022 01:00
@eracah eracah requested a review from karan6181 December 9, 2022 01:00
mvpatel2000
mvpatel2000 reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. do we need integration tests

tests/utils/object_store/object_store_settings.py Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Dec 9, 2022
View reviewed changes
composer/utils/file_helpers.py Show resolved Hide resolved
composer/utils/object_store/oci_object_store.py Outdated Show resolved Hide resolved
composer/utils/object_store/oci_object_store.py Outdated Show resolved Hide resolved
composer/utils/object_store/oci_object_store.py Outdated Show resolved Hide resolved
composer/utils/object_store/oci_object_store.py Outdated Show resolved Hide resolved
composer/utils/object_store/oci_object_store.py Outdated Show resolved Hide resolved
composer/utils/object_store/oci_object_store.py Show resolved Hide resolved
@eracah
Copy link
Contributor Author

eracah commented Dec 10, 2022

LGTM. do we need integration tests

at some point yes, but maybe wait until all the integration test infra is all set

mvpatel2000
mvpatel2000 approved these changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

mvpatel2000
mvpatel2000 reviewed Dec 11, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@eracah eracah merged commit 2acfaed into mosaicml:dev Dec 13, 2022
@eracah eracah deleted the oci-store branch December 13, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@dakinggg dakinggg dakinggg approved these changes

@karan6181 karan6181 Awaiting requested review from karan6181

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eracah @karan6181 @mvpatel2000 @dakinggg