Check and make sure that metric names is a list of strings #1798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If you accidentally pass a string to
Evaluator
formetric_names
, you get a semi nasty silent error of not actually filtering your metrics, because_filter_metrics
will happily loop over the string you provided. This PR explicitly checks that the input ofmetric_names
is a list.What issue(s) does this change relate to?
Closes CO-1505
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)