Add NLP Algorithms Tests #1839
Merged
Add NLP Algorithms Tests #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Dec 20, 2022
There was a problem hiding this comment.
Mostly looks good, thanks! Left a bunch of minor comments. Also, for any of the follow up work you mention in the PR description, if you could make a JIRA and link it that would be great. Lastly, I think we still need to add some stuff for Alibi and SeqLengthWarmup in tests/algorithms/algorithm_settings.py. These are used for the tests that test all algorithms. Maybe this is coming in your export PR/commits though
…nto nikhil/nlp-testing
dakinggg
approved these changes
Jan 12, 2023
mvpatel2000
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates many algorithms tests to run on NLP models, as guided by our NLP testing plan: https://www.notion.so/NLP-74e31fb2d8f0472e9fcd6fd98dd67686
The testing plan states that all algorithms that support NLP models should have tests that run on a HuggingFace BERT model and a Simple Transformer model.
Note: Tests for Stochastic Weight Averaging do not exist, but should be implemented by the original author. That is outside the scope of this PR (JIRA: CO-1611)
All other algorithms NLP algorithms are included in this PR. However,
test_factorize_algorithm.pyfails on some SimpleTransformer model tests. The Factorize algorithm needs to be improved to account for this. Included in this PR is updated documentation making clear its shortcoming (JIRA: CO-1612)Additional PRs will include tests for exporting NLP models.