-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/lambada evaluator #1845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmosaicml
force-pushed
the
feature/lambada_evaluator
branch
from
December 22, 2022 23:55
13838c1
to
6a3de37
Compare
bmosaicml
requested review from
a team,
knighton and
karan6181
as code owners
December 25, 2022 22:15
dakinggg
reviewed
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bunch of comments, mostly about integrating everything nicely with composer, and other clean code stuff like tests and docstrings. The implementation itself looks correct to me. Happy to help with any of the comments related to integrating it with composer if you want!
abhi-mosaic
reviewed
Dec 31, 2022
bmosaicml
force-pushed
the
feature/lambada_evaluator
branch
from
January 2, 2023 21:36
6a3de37
to
94f5ecb
Compare
abhi-mosaic
reviewed
Jan 3, 2023
abhi-mosaic
reviewed
Jan 3, 2023
bmosaicml
force-pushed
the
feature/lambada_evaluator
branch
from
January 3, 2023 18:41
94f5ecb
to
9744e9f
Compare
dakinggg
reviewed
Jan 4, 2023
bmosaicml
force-pushed
the
feature/lambada_evaluator
branch
from
January 9, 2023 20:24
9744e9f
to
76e9d37
Compare
jemdohmann
reviewed
Jan 9, 2023
bmosaicml
force-pushed
the
feature/lambada_evaluator
branch
from
January 9, 2023 20:46
76e9d37
to
e934acc
Compare
bmosaicml
force-pushed
the
feature/lambada_evaluator
branch
from
January 9, 2023 20:59
e934acc
to
677228e
Compare
dakinggg
approved these changes
Jan 9, 2023
knighton
reviewed
Jan 9, 2023
knighton
reviewed
Jan 9, 2023
knighton
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements a composer-native evaluator for Lambada.
What issue(s) does this change relate to?
Previously we were dependent on the Eleuther eval harness to run Eval, which was implemented inefficiently and couldn't support multi GPU. We now support LAMBADA with multi-gpu and enjoy linear scaling w/ num GPUs.
This is related to the following JIRA https://mosaicml.atlassian.net/browse/RESEARCH-345
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)