Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting daily tests passing #1893

Merged
merged 7 commits into from
Jan 20, 2023
Merged

Getting daily tests passing #1893

merged 7 commits into from
Jan 20, 2023

Conversation

dakinggg
Copy link
Contributor

What does this PR do?

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg requested a review from mvpatel2000 January 20, 2023 01:40
@dakinggg dakinggg marked this pull request as ready for review January 20, 2023 01:40
@dakinggg dakinggg enabled auto-merge (squash) January 20, 2023 01:40
mvpatel2000
mvpatel2000 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dakinggg dakinggg merged commit cf51d37 into dev Jan 20, 2023
@dakinggg dakinggg deleted the daniel/daily branch January 20, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @mvpatel2000