Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MCP GHA Name #1951

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Update MCP GHA Name #1951

merged 2 commits into from
Feb 7, 2023

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Feb 7, 2023 •
edited by jira bot
Loading

What does this PR do?

Rename mcp tests in mcloud to include more descriptive names of whats running

What issue(s) does this change relate to?

CO-1737

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner February 7, 2023 20:43
@mvpatel2000 mvpatel2000 changed the title update name Update MCP GHA Name Feb 7, 2023
bandish-shah
bandish-shah approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, pls see comment about passing branches to the MCLI run name.

@mvpatel2000 mvpatel2000 merged commit a918b2c into mosaicml:dev Feb 7, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/rename-mcp branch February 7, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bandish-shah bandish-shah bandish-shah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @bandish-shah