Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow eval metrics to be passed in to HuggingFaceModel directly #1971

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Feb 15, 2023

What does this PR do?

Previously HuggingFaceModel automatically used metrics for both train_metrics and eval_metrics. This can cause an issue if using Evaluators with metrics that can't be applied during training (e.g. ICL metrics). Now, if you pass in eval_metrics, it will use that for eval_metrics instead.

What issue(s) does this change relate to?

CO-1788

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review February 15, 2023 19:53
@dakinggg dakinggg requested a review from a team as a code owner February 15, 2023 19:53
@dakinggg dakinggg requested a review from nik-mosaic February 15, 2023 19:53
Copy link
Contributor

@nik-mosaic nik-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. Nice, simple code. Approved!

@dakinggg dakinggg merged commit 75697fa into mosaicml:dev Feb 15, 2023
@dakinggg dakinggg deleted the hf_eval_metrics branch June 1, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants