Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util for writing HuggingFace save_pretrained from a composer checkpoint #1974

Merged
merged 11 commits into from
Feb 17, 2023

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Feb 16, 2023

What does this PR do?

Adds a basic util function to load a composer checkpoint of a HuggingFaceModel and write out the config.json and pytorch_model.bin that are expected in a huggingface pretrained folder.

What issue(s) does this change relate to?

CO-1445

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review February 16, 2023 19:37
@dakinggg dakinggg requested a review from a team as a code owner February 16, 2023 19:37
Copy link
Contributor

@nik-mosaic nik-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and helpful. Approved.

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dakinggg dakinggg merged commit d8847b3 into mosaicml:dev Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants