Speed monitor refactor #1987
Merged
Speed monitor refactor #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussing offline with Vitaliy about if we want to include the cost estimate stuff. PR is being held until that is finalized. Would like review from examples repo folks that the changes ive made to speed monitor are fine in description |
Per discussion with @abhi-mosaic and @vchiley, we will not include the cost estimates. So this is ready for review! |
dakinggg
reviewed
Feb 23, 2023
dakinggg
reviewed
Feb 24, 2023
dakinggg
approved these changes
Feb 24, 2023
bmosaicml
pushed a commit
to bmosaicml/composer
that referenced
this pull request
Mar 2, 2023
* add speed monitor refactor * fix docs * fix tests * fix remove 1 * extend test * format * respond to comments * restore caching * add deepcopy * add comment
bmosaicml
pushed a commit
to bmosaicml/composer
that referenced
this pull request
Mar 2, 2023
* add speed monitor refactor * fix docs * fix tests * fix remove 1 * extend test * format * respond to comments * restore caching * add deepcopy * add comment
bmosaicml
pushed a commit
to bmosaicml/composer
that referenced
this pull request
Mar 2, 2023
* add speed monitor refactor * fix docs * fix tests * fix remove 1 * extend test * format * respond to comments * restore caching * add deepcopy * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Revamps Speed Monitor to track a whole bunch of metrics from per device to MFU. This is mostly upstreamed from examples repo
Changes:
flops_per_batch, letting user specify assumptions of forward vs. backwardstate.dataloader.dataset.max_seq_lenScreenshot:
w diffusion models
What issue(s) does this change relate to?
CO-1761