Add some logic to pass the correct github ref to mcp script #1990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds logic to the
pytest-gpu
workflow to pass the correct Github reference to themcp
test runner. If the workflow is triggered by an event in a pull request, it will use the PR number. Otherwise the commit SHA will be used if the run is on a protected branch, else the branch name is used.Testing
Temporarily added
pull_request
trigger to kick off thedaily
workflow in this PR:https://github.com/mosaicml/composer/actions/runs/4247384552/jobs/7385370010
GPU runs failed due to a failing test in
dev
so this is expected. Fix for that will be in another PR but should not block this PR.Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)To Do
pull_request
trigger that was added to testdaily
workflow