Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optimizer monitor test gating with FSDP #2000

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Fix optimizer monitor test gating with FSDP #2000

merged 1 commit into from
Feb 25, 2023

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Fix optimizer monitor test gating with FSDP. Requires torch 1.13 for FSDP

eracah
eracah approved these changes Feb 25, 2023
View reviewed changes
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvpatel2000 mvpatel2000 enabled auto-merge (squash) February 25, 2023 01:23
@mvpatel2000 mvpatel2000 merged commit d406cd6 into mosaicml:dev Feb 25, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/fix-fsdp-gating branch February 25, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@eracah eracah eracah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvpatel2000 @eracah @dakinggg