-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect for missing slack_sdk
import
#2031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we gate pynvml the same way?
manual testing evidence
|
New round of manual checks without pynvml or slack_sdk
with pynvml, without slack_sdk
with pynvml and slack_sdk
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
What does this PR do?
Fixes #2030 .
slack_sdk
is not in the base install, so theHealthChecker
needs to check the import.Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)