Backward Compat with Torchmetrics #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
approved these changes
Mar 9, 2023
bandish-shah
pushed a commit
that referenced
this pull request
Mar 14, 2023
* backwards compatbility * fix test * debug * safe load * add logs * remove print * add print * flip check * fix eval * add lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We currently lose backwards compatibility due to a breaking change in torchmetrics. This PR monkeypatches on a new attribute necessary for restoring checkpoints. It also raises an error when trying to restore metrics which had API changes.
Testing with monkeypatched function
Testing with error raised when hitting accuracy.
What issue(s) does this change relate to?
CO-1894