Raise error if attempting to export FSDP model #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
approved these changes
Mar 9, 2023
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
bandish-shah
pushed a commit
that referenced
this pull request
Mar 14, 2023
* raise error if FSDP model * Update composer/utils/inference.py Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com> * fix --------- Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com> Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our export for inference method requires a deepcopy in order to avoid side effects on the model, especially when exporting during training.
FSDP currently does not support deepcopies, so this PR throws an error to give a more informative error.