Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Checkpoints Simplified (#2041)" #2056

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

dakinggg
Copy link
Contributor

This reverts commit 25c9a67.

What does this PR do?

Reverts the recent checkpointing simplification because it seems to cause a hang in autoresume, blocking #2054. Reverting until we can debug further

What issue(s) does this change relate to?

N/A

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review March 10, 2023 03:40
@dakinggg dakinggg requested a review from mvpatel2000 March 10, 2023 03:40
@dakinggg dakinggg enabled auto-merge (squash) March 10, 2023 03:51
@dakinggg dakinggg merged commit 0ef85dc into mosaicml:dev Mar 10, 2023
bandish-shah pushed a commit that referenced this pull request Mar 14, 2023
@dakinggg dakinggg deleted the revert-checkpointing branch June 1, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants