Busy wait so that non local rank zeros don't timeout while local rank zero downloads a monolithic checkpoint #2071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before the
dist.barrier()
indownload_checkpoint
, busy wait for local rank 0 to reach that part of the code. This prevents a timeout on the barrier when it takes local rank 0 a long time to download the checkpoint.Manual test passed
What issue(s) does this change relate to?
Closes CO-1881
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)