Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Busy wait so that non local rank zeros don't timeout while local rank zero downloads a monolithic checkpoint #2071

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Mar 15, 2023

What does this PR do?

Before the dist.barrier() in download_checkpoint, busy wait for local rank 0 to reach that part of the code. This prevents a timeout on the barrier when it takes local rank 0 a long time to download the checkpoint.

Manual test passed

What issue(s) does this change relate to?

Closes CO-1881

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review March 15, 2023 04:09
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and passes manual test

@eracah eracah merged commit a7f33cb into mosaicml:dev Mar 15, 2023
bandish-shah pushed a commit that referenced this pull request Mar 15, 2023
@dakinggg dakinggg deleted the busy-wait branch June 1, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants