-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update support for HumanEval #2550
Conversation
…lso using the HumanEval estimator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a unit test?
Sure, @mvpatel2000. Would it be acceptable to use the previous tests (#2301?), update (set different values of |
Yep, should be fine to update previous tests. No need to paste output -- CI/CD will run it automatically so as long as it passes it should be fine |
@mvpatel2000 @dakinggg, open to any more input. Otherwise, latest is passing tests and I've resolved other asks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but will wait for Daniel to approve since he has more context
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Updated the support for HumanEval to compute the pass@k metric with n samples. This specifically, separates n and k, which were previously coupled together to have the same value. Now we can compute pass@k with n > k as is the case for implementations in other work.
What issue(s) does this change relate to?
N/A
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)