Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gate HSDP by torch 2.1.0 #2656

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Gate HSDP by torch 2.1.0 #2656

merged 5 commits into from
Oct 19, 2023

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Oct 18, 2023 •
edited
Loading

What does this PR do?

Gate torch import by 2.1.0. We are not confident checkpointing works on earlier versions per @eracah

@mvpatel2000 mvpatel2000 requested a review from eracah October 18, 2023 23:55
b-chu
b-chu reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know that it breaks on 2.0.1 and works on 2.1.0 for certain?

@mvpatel2000
Copy link
Contributor Author

Do we know that it breaks on 2.0.1 and works on 2.1.0 for certain?

We know for sure it works on 2.1.0. Community users reported issues with 2.0.1

j316chuck
j316chuck approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@j316chuck j316chuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we pin the version for 2.1.0?

composer/utils/checkpoint.py Show resolved Hide resolved
@mvpatel2000 mvpatel2000 merged commit 12d31ce into mosaicml:dev Oct 19, 2023
15 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/require-21 branch October 19, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-chu b-chu b-chu left review comments

@j316chuck j316chuck j316chuck approved these changes

@eracah eracah Awaiting requested review from eracah

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvpatel2000 @j316chuck @b-chu