Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FSDP arg default to match torch #2660

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix FSDP arg default to match torch #2660

merged 1 commit into from
Oct 20, 2023

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Oct 20, 2023 •
edited
Loading

What does this PR do?

Fix FSDP arg default to match torch for limit all gathers

image

j316chuck
j316chuck approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@j316chuck j316chuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvpatel2000 mvpatel2000 merged commit 13ab2f5 into mosaicml:dev Oct 20, 2023
15 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/fix-default branch October 20, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j316chuck j316chuck j316chuck approved these changes

@b-chu b-chu Awaiting requested review from b-chu

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @j316chuck