-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to validate remote object store paths #2667
Conversation
qq: Is this script supposed to be used locally in interactive session since there already exists an mcli yaml? |
@j316chuck the mcli yaml that i was using only supports s3, so i figured this would be an easy way to check all backends easily and through composer as well. Though, if this script fails, it doesn't necessarily rule out composer issues. I'll write an mcli yaml for this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this part of the library instead of a script? similar to composer_collect_env
@dakinggg good suggestion! so it would both in the library as well as a script, yeah? |
Yeah, exact same as composer_collect_env setup |
@dakinggg I think the best move would be to create a |
Can you define |
@dakinggg Tried it, but it won't work--it needs to a be a function that takes no arguments. So we could (1) keep a tiny script in |
I think Its possible to set it up with args parsed by argparse. because the |
57d2448
to
ea1ab33
Compare
What does this PR do?
Adds a script that validates remote object store paths using composer utility functions.
This is helpful for debugging especially on remote runs.
What issue(s) does this change relate to?
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)