Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S] Add tag support to MLFlowLogger #2716

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[S] Add tag support to MLFlowLogger #2716

merged 1 commit into from
Nov 17, 2023

Conversation

aspfohl
Copy link
Contributor

@aspfohl aspfohl commented Nov 15, 2023

What does this PR do?

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right? Would be nice to have someone on the mlflow side review

@eracah
Copy link
Contributor

eracah commented Nov 16, 2023

@prithvikannan

Copy link
Contributor

@prithvikannan prithvikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aspfohl aspfohl merged commit 1b28293 into dev Nov 17, 2023
16 checks passed
@aspfohl aspfohl deleted the anna/mlflow-tags branch November 17, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants