Fix activation cpu offloading #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
approved these changes
Nov 17, 2023
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
mvpatel2000
approved these changes
Nov 17, 2023
mvpatel2000
approved these changes
Nov 20, 2023
|
@mvpatel2000 added unit test and inline import |
mvpatel2000
approved these changes
Nov 22, 2023
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes activation cpu offloading. The original implementation 1) breaks when offload_to_cpu is enabled and activation_checkpointing is disabled 2) does not offload to cpu when activation_checkpointing and offload_to_cpu are both enabled. See pytorch/pytorch#85459.