Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profiler issue #2735

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix profiler issue #2735

merged 1 commit into from
Nov 21, 2023

Conversation

j316chuck
Copy link
Contributor

@j316chuck j316chuck commented Nov 20, 2023 •
edited
Loading

What does this PR do?

Fix profiler logging issue where we don't log memory stats if it does not exist.

Tests:

  • Test run with memory: b-e-2node-fwdprefetch-opoekS
  • Test run without memory: b-e-2node-fwdprefetch-profile-mem-false-QbAYbV

What issue(s) does this change relate to?

https://databricks.atlassian.net/browse/GRT-2584

@j316chuck j316chuck requested a review from a team as a code owner November 20, 2023 23:28
@j316chuck j316chuck merged commit a193115 into dev Nov 21, 2023
16 checks passed
@j316chuck j316chuck deleted the chuck/fix_profiler branch November 21, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j316chuck @dakinggg