Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated for loop in lr_monitor.py #2738

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

priba
Copy link
Contributor

@priba priba commented Nov 23, 2023

What does this PR do?

Removes a duplicated for loop in the LRMonitor callback.

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@priba
Copy link
Contributor Author

priba commented Nov 28, 2023

@mvpatel2000 @eracah any change I can get a review here?

Currently LRMonitor logs repeated information due to a duplication of the for loop.

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

Apologies for the delayed review, didn't see the PR go up. In the future, feel free to tag me as a reviewer on github in top right and I can triage as appropriate :)

As always, appreciate the contribution!

@priba
Copy link
Contributor Author

priba commented Nov 28, 2023

Thanks @mvpatel2000

@mvpatel2000 mvpatel2000 merged commit 6b517cb into mosaicml:dev Nov 28, 2023
16 checks passed
@priba priba deleted the priba/lr_monitor_loop branch November 29, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants