Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore load ignore keys #2748

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Ignore load ignore keys #2748

merged 3 commits into from
Nov 29, 2023

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Ignore load ignore keys as that should only apply to initial autoresume

@mvpatel2000 mvpatel2000 requested review from dakinggg and eracah and removed request for dakinggg November 29, 2023 18:58
dakinggg
dakinggg approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple test please? This is an edge case we hadn't considered, so I'd like to cover it.

@mvpatel2000
Copy link
Contributor Author

Can you add a simple test please? This is an edge case we hadn't considered, so I'd like to cover it.

Added unit test. Also verified it fails before

@mvpatel2000 mvpatel2000 merged commit 66f412d into mosaicml:dev Nov 29, 2023
16 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/tweak-autoresume branch November 29, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@eracah eracah Awaiting requested review from eracah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @dakinggg