Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load RNG keys that exist #2901

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Only load RNG keys that exist. This was broken in #2897 but was not caught in manual tests for some reason 🤔

@mvpatel2000 mvpatel2000 requested a review from eracah January 24, 2024 18:20
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LDTM

@mvpatel2000 mvpatel2000 merged commit 2553e54 into mosaicml:dev Jan 25, 2024
16 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/rng-fix branch January 25, 2024 00:50
ShashankMosaicML pushed a commit to ShashankMosaicML/composer that referenced this pull request Feb 3, 2024
ShashankMosaicML pushed a commit to ShashankMosaicML/composer that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants