Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a register_model_with_run_id api to MLflowLogger #2967

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Add a register_model_with_run_id api to MLflowLogger #2967

merged 8 commits into from
Feb 7, 2024

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Feb 6, 2024 •
edited
Loading

This is a different way or registering the model that is necessary if you want to preserve the link to the mlflow run.

Manually tested that the link to the run is preserved.
Screenshot 2024-02-06 at 6 26 10 PM

@dakinggg dakinggg mentioned this pull request Feb 6, 2024
Merged
@dakinggg dakinggg requested a review from irenedea February 7, 2024 02:23
@dakinggg dakinggg marked this pull request as ready for review February 7, 2024 02:27
@dakinggg dakinggg requested review from eracah and a team as code owners February 7, 2024 02:27
irenedea
irenedea reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just had some questions

composer/loggers/mlflow_logger.py Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
irenedea
irenedea approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
@dakinggg dakinggg changed the title Add a create_model_version api to MLflowLogger Add a register_model_with_run_id api to MLflowLogger Feb 7, 2024
@dakinggg dakinggg enabled auto-merge (squash) February 7, 2024 20:54
@dakinggg dakinggg merged commit cb048e5 into mosaicml:dev Feb 7, 2024
14 checks passed
mvpatel2000 pushed a commit that referenced this pull request Feb 8, 2024
@dakinggg @mvpatel2000
Add a register_model_with_run_id api to MLflowLogger (#2967)
0b643bb
@dakinggg dakinggg deleted the mlf-crt branch February 10, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea approved these changes

@eracah eracah eracah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @eracah @irenedea