Skip extra dataset state load #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snarayan21
reviewed
Jun 11, 2024
mvpatel2000
added a commit
to mvpatel2000/composer
that referenced
this pull request
Jul 21, 2024
* fix edge case * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip extra dataset state load. Previously, if loading a checkpoint with
train_dataloader, we would first load the dataset_state on load. After loading, if we again set train_dataloader, it would callload_state_dictwith a state_dict that had a value ofNone. This fixes the check on the setter oftrain_dataloaderto properly skip the extra load.