Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin checkpoint state dict flattening patch #3700

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Pin checkpoint state dict flattening patch #3700

merged 1 commit into from
Nov 4, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Nov 4, 2024

What does this PR do?

Pytorch fixed this in 2.5 so the patch is no longer needed
https://github.com/mosaicml/composer/actions/runs/11666678682

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu requested review from bigning and mvpatel2000 November 4, 2024 15:20
@b-chu b-chu merged commit 03c992b into main Nov 4, 2024
14 checks passed
@b-chu b-chu deleted the checkpoint branch November 4, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants