Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICL fixes #176

Closed
wants to merge 10 commits into from
Closed

ICL fixes #176

wants to merge 10 commits into from

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Feb 16, 2023 •
edited
Loading

  • adds a seed to the eval script.
  • adds a space for the continuation delimiter, per @bmosaicml
  • allows passing in loggers
  • [most important] passes through the destination_path param. having the same destination_path for multiple datasets leads to race conditions

This PR cannot be merged until the next composer release (PR mosaicml/composer#1978), because the destination_path cannot be passed through

@dakinggg dakinggg requested a review from bmosaicml February 16, 2023 22:29
@dakinggg dakinggg marked this pull request as draft February 17, 2023 02:06
@dakinggg dakinggg changed the title add logger parsing to evaluation script ICL fixes Feb 17, 2023
@dakinggg dakinggg requested a review from abhi-mosaic February 17, 2023 05:15
@dakinggg dakinggg closed this May 12, 2023
@dakinggg dakinggg deleted the wandb_to_eval branch September 9, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmosaicml bmosaicml Awaiting requested review from bmosaicml

@abhi-mosaic abhi-mosaic Awaiting requested review from abhi-mosaic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dakinggg