Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding MCloud Nemo Megatron example #84

Merged
merged 11 commits into from
Feb 3, 2023
Merged

Adding MCloud Nemo Megatron example #84

merged 11 commits into from
Feb 3, 2023

Conversation

bcui19
Copy link
Contributor

@bcui19 bcui19 commented Jan 24, 2023

We add documentation on how to run Nemo Megatron in MCloud

@abhi-mosaic
Copy link
Contributor

QQ, if we want to match the format of the existing projects (bert, llm, etc.), maybe it would make sense to organize this as a top level folder nemo, and then put mcloud examples inside? The other folders also have mcloud examples inside so it would kinda match.

lupesko
lupesko suggested changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@lupesko lupesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested updates.
I assume you ran this and ensured it works. LMK if you want to double verify, happy to run and confirm.

mcloud_examples/nemo_megatron/README.md Outdated Show resolved Hide resolved
mcloud_examples/nemo_megatron/README.md Outdated Show resolved Hide resolved
mcloud_examples/nemo_megatron/README.md Outdated Show resolved Hide resolved
mcloud_examples/nemo_megatron/README.md Outdated Show resolved Hide resolved
mcloud_examples/nemo_megatron/README.md Outdated Show resolved Hide resolved
mcloud_examples/nemo_megatron/README.md Outdated Show resolved Hide resolved
mcloud_examples/nemo_megatron/multi_node.yaml Outdated Show resolved Hide resolved
mcloud_examples/nemo_megatron/single_node.yaml Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Jan 24, 2023
View reviewed changes
nemo/single_node.yaml Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Jan 24, 2023
View reviewed changes
nemo/single_node.yaml Outdated Show resolved Hide resolved
@bcui19 bcui19 requested a review from dakinggg January 25, 2023 17:45
dakinggg
dakinggg approved these changes Feb 3, 2023
View reviewed changes
nemo/README.md Outdated Show resolved Hide resolved
@bcui19 bcui19 requested a review from lupesko February 3, 2023 23:56
@lupesko lupesko merged commit 7b8d888 into mosaicml:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@lupesko lupesko lupesko approved these changes

@hanlint hanlint Awaiting requested review from hanlint

@abhi-mosaic abhi-mosaic Awaiting requested review from abhi-mosaic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcui19 @abhi-mosaic @lupesko @dakinggg