Get a shared file system safe signal file name #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
approved these changes
Jul 23, 2024
dakinggg
added a commit
to dakinggg/llm-foundry
that referenced
this pull request
Jul 23, 2024
…)" This reverts commit d2d29ad.
dakinggg
added a commit
that referenced
this pull request
Jul 23, 2024
|
Hey, what was the reason to revert the commit? :) |
|
Hi, yes we reverted due to a bug in the released version of the helper function (did not work on systems where distributed was not initialized). That bug has since been fixed, and this commit should be reapplied. Thanks for the reminder! |
janEbert
pushed a commit
to TrustLLMeu/llm-foundry
that referenced
this pull request
Sep 3, 2024
janEbert
pushed a commit
to TrustLLMeu/llm-foundry
that referenced
this pull request
Oct 12, 2024
ofivite
pushed a commit
to ofivite/llm-foundry
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the previously added utils to get a signal file name that is safe on shared file systems. Previously the name would clash.
Tested simple train and load (don't have a multinode shared fs to actually test that part on):
train: dist-utils-train-1-UExzEF
load: dist-utils-load-2-Uoq35b
See also mosaicml/composer#3485