Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn instead of error on tokenizer-only download with http #904

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Warn instead of error on tokenizer-only download with http #904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9964fe8
Warn instead of error on tokenizer-only with http
jerrychen109 Jan 24, 2024
520fdf2
Merge branch 'main' into jerry/fix-tokenizer-download
jerrychen109 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/misc/download_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,9 @@ def parse_args() -> argparse.Namespace:

if download_from == 'http':
if args.tokenizer_only:
raise ValueError(
'tokenizer-only is not currently supported for http.')
log.warning(
'tokenizer-only is not currently supported for http. Downloading all files instead.'
)
try:
download_from_http_fileserver(args.url, args.save_dir,
args.ignore_cert)
Expand Down
Loading