Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make __getitem__ block to download shard if not present. #118

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

knighton
Copy link
Contributor

Description of changes:

Make StreamingDataset[sample_id] block to download the given sample's shard if it is not present, so that the dataset can be used lazily.

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you done any manual testing to test the scenario where the locks are necessary (i.e. one worker accesses while another is downloading the necessary shard)? That sounds like a fairly complex unit test to write, but would be good to somehow verify that functionality. Your comments in this PR is also making me think that we should have some basic regression testing for streaming...

tests/test_laziness.py Outdated Show resolved Hide resolved
@knighton knighton merged commit 41c3c27 into main Jan 10, 2023
@knighton knighton deleted the james/lazy branch January 10, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants