Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unittest for Writer and Reader #16

Merged
merged 5 commits into from
Sep 19, 2022
Merged

Added unittest for Writer and Reader #16

merged 5 commits into from
Sep 19, 2022

Conversation

karan6181
Copy link
Collaborator

Description

knighton
knighton reviewed Sep 19, 2022
View reviewed changes
tests/test_streaming.py Outdated Show resolved Hide resolved
knighton
knighton approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@knighton knighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also may rename v1 shard_size_limit to v2 size_limit

@karan6181
Copy link
Collaborator Author

shard_size_limit

Thanks! Done in ef5d173.

@karan6181 karan6181 merged commit 73d114d into mosaicml:main Sep 19, 2022
@karan6181 karan6181 deleted the test branch September 19, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knighton knighton knighton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karan6181 @knighton