New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip pre-commit check for enwiki convert skip to have code parity #32

Merged

karan6181 merged 2 commits into mosaicml:main from karan6181:skip_precommit_for_enwiki_convert

Oct 6, 2022

Collaborator

karan6181 commented Oct 6, 2022

Description

PR Fix preprocessing for English Wikipedia dataset #28 added a Enwiki dataset conversion scripts for streaming.
As part of the code parity with the official tfrecord preprocessing, pre-commit fails with multiple linting problem. Hence, this PR exclude the enwiki convert directory pre-commit checks.
As part of a long term vision, we should move all those scripts to a common sub-folders.


          Skip pre-commit check for enwiki convert skip to have code parity

116c60c

karan6181 commented

View reviewed changes

streaming/text/enwiki.py Show resolved Hide resolved


          Merge branch 'main' into skip_precommit_for_enwiki_convert

f2ff835

knighton approved these changes

View reviewed changes

karan6181 merged commit 1cac156 into mosaicml:main

karan6181 deleted the skip_precommit_for_enwiki_convert branch

October 6, 2022 23:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet