-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added default behavior if no streams and epoch_size specified #348
Merged
snarayan21
merged 24 commits into
mosaicml:main
from
snarayan21:epoch_size_single_stream
Jul 31, 2023
Merged
added default behavior if no streams and epoch_size specified #348
snarayan21
merged 24 commits into
mosaicml:main
from
snarayan21:epoch_size_single_stream
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karan6181
reviewed
Jul 28, 2023
snarayan21
force-pushed
the
epoch_size_single_stream
branch
from
July 28, 2023 23:52
11672fe
to
eb3d02d
Compare
karan6181
reviewed
Jul 31, 2023
This reverts commit acb0e0f.
…n21/saaketh-streaming into epoch_size_single_stream
karan6181
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank You!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added default behavior for when
epoch_size
is specified but no streams given inStreamingDataset
instantiation.Issue was that specifying
epoch_size
without any streams triggered aValueError
in theapply_weights
method of theStream
class because it didn't want choose to be specified for the whole epoch unless weighting relatively. But with just one stream, the epoch_size would only apply to one stream, so we would chooseepoch_size
elements over the single dataset per epoch.Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)