Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff to 0.2.2 #608

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Update ruff to 0.2.2 #608

merged 3 commits into from
Mar 5, 2024

Conversation

Skylion007
Copy link
Contributor

Description of changes:

Issue #, if available:

Updates ruff to 0.2.2 and enables a few more checks that I just enabled in Composer and elsewhere.

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@snarayan21
Copy link
Collaborator

@Skylion007 could you elaborate more on what the changes are? just want to have this documented before merging

@karan6181
Copy link
Collaborator

@Skylion007 could you elaborate more on what the changes are? just want to have this documented before merging

I think the point here is to keep the linting repo up to date.

@karan6181 karan6181 merged commit b4a317c into main Mar 5, 2024
7 checks passed
@karan6181 karan6181 deleted the skylion007/update-ruff-0.2.2 branch March 5, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants