Add support for Alipan Storage backend #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `download_from_alipan` function and `AlipanUploader` class * Add tests for both download and upload * Add docs for configure Alipan Storage Credentials * Add `AliPCS-Py` to setup.py as extra dependence
PeterDing
requested review from
knighton,
karan6181 and
bandish-shah
as code owners
karan6181
reviewed
Apr 13, 2024
* Use accurate `download_file` instead of the general `download` when download a remote file * Raise a `ValueError` when the remote is `None` at uploading * Format code
PeterDing
commented
Apr 14, 2024
snarayan21
reviewed
May 9, 2024
There was a problem hiding this comment.
Hey @PeterDing, just getting back to this now. Left a couple of suggestions and comments. Are there any other changes you'd like to make?
docs/source/how_to_guides/configure_cloud_storage_credentials.md
Outdated
Show resolved
Hide resolved
docs/source/how_to_guides/configure_cloud_storage_credentials.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com>
snarayan21
approved these changes
May 10, 2024
|
@PeterDing It would be most helpful if we could refer users to you if they face issues with Alipan. You are much more well versed with Alipan stuff than our team :) Excited to get this integrated into Streaming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to access Alipan Storage.
Description of changes:
Add
download_from_alipanfunction andAlipanUploaderclassAdd tests for both download and upload
Add docs for configure Alipan Storage Credentials
Add
AliPCS-Pyto setup.py as extra dependenceIssue #, if available:
Merge Checklist:
Put an
xwithout space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commiton my change. (check out thepre-commitsection of prerequisites)