remove v0.7.0 warning #788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
reviewed
Sep 23, 2024
| f'8*batch_size if batch_size is not None, otherwise 64. Prior to ' + | ||
| f'Streaming v0.7.0, `predownload` defaulted to ' + | ||
| f'max(batch_size, 256 * batch_size // num_canonical_nodes).') | ||
| f'8*batch_size if batch_size is not None, otherwise 64.') |
There was a problem hiding this comment.
we shoudl lower to logger.info
| @@ -671,8 +669,7 @@ def _set_shuffle_block_size(self, world: World): | |||
| if not world.worker_of_rank: | |||
| logger.warning(f'Because `shuffle_block_size` was not specified, it will ' + | |||
| f'default to max(4_000_000 // num_canonical_nodes, 1 << 18) if ' + | |||
| f'num_canonical_nodes is not None, otherwise 262144. Prior to ' + | |||
| f'Streaming v0.7.0, `shuffle_block_size` defaulted to 262144.') | |||
| f'num_canonical_nodes is not None, otherwise 262144.') | |||
There was a problem hiding this comment.
we should lower to logger.info
| f'be equal to physical nodes. Prior to Streaming ' + | ||
| f'v0.7.0, `num_canonical_nodes` defaulted to 64 * physical ' + | ||
| f'nodes.') | ||
| f'be equal to physical nodes.') |
There was a problem hiding this comment.
we should lower to logger.info
| f'be equal to physical nodes. Prior to Streaming ' + | ||
| f'v0.7.0, `num_canonical_nodes` defaulted to 64 * physical ' + | ||
| f'nodes.') | ||
| f'be equal to physical nodes.') |
There was a problem hiding this comment.
we should lower to logger.info
mvpatel2000
approved these changes
Sep 24, 2024
8 tasks
|
Closing in favor of #799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
remove part of the warning messages about v0.7.0 of streaming.
Issue #, if available:
Merge Checklist:
Put an
xwithout space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commiton my change. (check out thepre-commitsection of prerequisites)