Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add {fillInputAndData: true,} to eth_call on method_wrappers #1

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

moshmage
Copy link
Owner

@moshmage moshmage commented Aug 24, 2023

Description

The fillInputData option on formatTransaction call that was introduced with this change left eth_call method unchanged. In my case, 4.1.0 was unable to call a simple ERC20.name() returning unkown function selector (even if the contract had a fallback).

Adding this argument to the function call when call() is made fixed it on my side.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@moshmage moshmage merged commit 991a766 into 4.x Aug 24, 2023
@moshmage moshmage deleted the moshmage-fix-call-input-data branch August 24, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data is missing from methods.myMethod
1 participant