Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corrade-rc executable not found when build target WinRT #81 #82

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Fix corrade-rc executable not found when build target WinRT #81 #82

merged 1 commit into from
Nov 17, 2019

Conversation

linuxaged
Copy link
Contributor

building has passed on my machine.
but not sure what does "similar change would be in UseCorrade.cmake" mean in the TODO comment.

@mosra mosra added this to the 2019.1c milestone Nov 17, 2019
@mosra
Copy link
Owner

mosra commented Nov 17, 2019

Thanks for working on this!

I just restarted the AppVeyor build as it failed due to some network error, unrelated to your change :)
For UseCorrade.cmake I just checked and apparently nothing is needed anymore (it might have been in the past, which is why the comment). I'll merge this together with a documentation update later today.

For the magnum side of things, regarding OpenAL .. this would need to have vcpkg packages updated with "per-platform defaults" as described by the vcpkg maintainers at mosra/magnum#368. In the meantime installing magnum explicitly without audio should work (but yet again I forgot the correct command how to do that).

@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #82   +/-   ##
======================================
  Coverage    97.5%   97.5%           
======================================
  Files          87      87           
  Lines        5841    5841           
======================================
  Hits         5695    5695           
  Misses        146     146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb7ea2...1a71898. Read the comment docs.

@mosra mosra merged commit 1a71898 into mosra:master Nov 17, 2019
@mosra
Copy link
Owner

mosra commented Nov 17, 2019

Merged, thank you!

@mosra
Copy link
Owner

mosra commented Nov 18, 2019

Reverted in bb900a9, since the feature apparently wasn't ever implemented in CMake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants