Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-emscripten: Use EmscriptenApplication #17

Closed
wants to merge 1 commit into from

Conversation

Squareys
Copy link

Hi @mosra!

As part of mosra/magnum#300 I thought it may make sense to also update base-emscripten. I hesitated, since desktop builds are now no longer supported. But I guess that's what the base branch is for, and this is meant as the most emscripten specific thing as far as I understand it.

This is ready once EmscriptenApplication is ready.

Cheers, Jonathan

@Squareys
Copy link
Author

The EmscriptenApplication doc currently states:

Fully contained base application using @ref Sdl2Application for desktop build
and @ref EmscriptenApplication for Emscripten build and CMake setup is available
in `base-emscripten` branch of
[Magnum Bootstrap](https://github.com/mosra/magnum-bootstrap) repository,
...

Which could also be an option... @mosra what do you prefer?

@mosra
Copy link
Owner

mosra commented May 17, 2019

The base-ios, base-android and base-winrt bootstrap projects all have both the native and the crosscompiled version, so I think it make sense to have that here as well. Besides that, Magnum design philosophy encourages people to develop natively first and then just cross-compile and having a bootstrap project that doesn't support native build would be against that.

@mosra mosra added this to the 2019.0b milestone May 17, 2019
@mosra mosra self-assigned this May 17, 2019
Signed-off-by: Squareys <squareys@googlemail.com>
@mosra mosra marked this pull request as ready for review June 10, 2019 10:23
@mosra
Copy link
Owner

mosra commented Jun 16, 2019

Merged in f9dbbaa, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants