Use EmscriptenApplication for emscripten ports #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squareys
force-pushed
the
emscripten-application
branch
from
ce1c86a to
4c328dc
Compare
24 tasks
Squareys
force-pushed
the
emscripten-application
branch
from
4c328dc to
0545d02
Compare
|
Note: With the current state, Chrome tabs crash on text example when loading the font (but works on firefox). (obsolete) |
mosra
requested changes
May 17, 2019
There was a problem hiding this comment.
Just minor things, the tabindex comment from #60 applies here as well.
Note: With the current state, Chrome tabs crash on text example when loading the font (but works on firefox).
Is that still a thing or not anymore? I remember you said it's gone.
Squareys
force-pushed
the
emscripten-application
branch
2 times, most recently
from
afbad9e to
c9cd997
Compare
Yeah, that's gone :) |
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
emscripten-application
branch
from
c9cd997 to
4a21a21
Compare
|
@mosra This is again ready for review! |
|
Merged as 3fb7bd8, with the imgui change being put directly into master as 4fae2fd. All the examples are now shipped on https://magnum.graphics/showcase/ and looking & behaving better than ever :) Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mosra !
As part of mosra/magnum#300, here are the adaptions to the emscripten example ports.
Cheers, Jonathan