Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXR Example #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WebXR Example #73

wants to merge 1 commit into from

Conversation

Squareys
Copy link
Contributor

@Squareys Squareys commented Dec 9, 2019

Hi @mosra,

as promised, with open sourcing of https://github.com/vhiterabbit/emscripten-webxr, here's a Magnum example.
This week, the first two browsers with support for the stable specification of the WebXR Device API will be released, hence I see it as valuable for magnum to be probably the first C++ graphics framework out there to support it.

Best,
Jonathan

TODO

  • Documentation & Screenshot
  • Changelog entry

@Squareys Squareys force-pushed the webxr-example branch 2 times, most recently from e9711bc to 8abcf07 Compare December 10, 2019 00:51
src/webxr/CMakeLists.txt Outdated Show resolved Hide resolved
@Squareys
Copy link
Contributor Author

@mosra This is ready for review! :)

@mosra mosra added this to the 2019.1c milestone Dec 11, 2019
Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A bunch of semi-minor things.

src/webxr/CMakeLists.txt Outdated Show resolved Hide resolved
src/webxr/CMakeLists.txt Outdated Show resolved Hide resolved
src/webxr/CMakeLists.txt Outdated Show resolved Hide resolved
src/webxr/CMakeLists.txt Outdated Show resolved Hide resolved
src/webxr/CMakeLists.txt Outdated Show resolved Hide resolved
doc/webxr.dox Outdated Show resolved Hide resolved
doc/changelog-examples.dox Outdated Show resolved Hide resolved
src/webxr/WebXrExample.cpp Outdated Show resolved Hide resolved
src/webxr/WebXrExample.cpp Outdated Show resolved Hide resolved
src/webxr/CMakeLists.txt Outdated Show resolved Hide resolved
emscripten-webxr is at e101ce7cfc3c92962a65771f43c2d61775edd348

Signed-off-by: Squareys <squareys@googlemail.com>
@Squareys
Copy link
Contributor Author

@mosra Done!

Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/webvr/CMakeLists.txt Show resolved Hide resolved
@mosra
Copy link
Owner

mosra commented Dec 12, 2019

Merged as 818731d, thank you! I'll update the docs and everything tomorrow, too late to do that today.

Keeping this open as a reminder until we solve the Closure Compiler issue I mentioned privately -- I'd like to upload the minified version, ideally ;)

@mosra mosra modified the milestones: 2020.06, 2020.0b Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants