-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octree #86
Octree #86
Conversation
…ore special treatments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope the amount of comments is not too overwhelming 😅
Thanks a lot for all the great examples, and an additional thanks for doing the CI/docs setup here as well 👍
|
||
void OctreeExample::mouseScrollEvent(MouseScrollEvent& event) { | ||
const Float delta = event.offset().y(); | ||
if(Math::abs(delta) < 1.0e-2f) { return; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(Math::abs(delta) < 1.0e-2f) { return; } | |
if(Math::abs(delta) < 1.0e-2f) return; |
No single-line blocks please. Same above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My automatic formatter refuses to do that 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you have to do that on your side, as whenever I save, the content got re-formatted to the same old stuff.
@mosra The code looks much better now 😃 |
058d478
to
45d0662
Compare
I am curious to see this works in WebGL 😄 |
Thank you! The last unresolved comment is https://github.com/mosra/magnum-examples/pull/86/files#r441446247, about making it possible to switch and benchmark the bruteforce method at runtime -- just want to know your opinion on that, and I'm fine with doing that myself post-merge :) |
Done. |
Merged in 5ff5175, thank you! :) |
Here is our new octree example 😈
@mosra, feel free to edit it. I could not think of a nicer teaser image. The simulation scene can be changed, such as the number of spheres, sphere size, sphere color etc.