-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten closure compiler breaks WebGL 2 calls #211
Comments
I threw away the closure compiler for good, so this is no longer relevant. 💥 |
Reopened as the closure compiler can gain us quite nice file size savings. Need to fix the bugs tho. |
Fix that makes all the test working with |
Fix released in Emscripten 1.38.21, once the release gets common enough, I'll re-add the flag to all toolchains. |
Since the flag causes significant compilation time increase, it won't get enabled by default. Instead, as of df6b414, there's a new section in the docs listing all extra Emscripten flags with code size / compilation time tradeoffs. |
There are some more cases following those I fixed back in emscripten-core/emscripten#3478 (for example
glVertexAttribIPointer()
). Temporary solution is to remove--closure 1
from toolchain flags (here).brew update
) and then re-add it to toolchainsThe text was updated successfully, but these errors were encountered: