Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten closure compiler breaks WebGL 2 calls #211

Closed
2 of 3 tasks
mosra opened this issue Jun 18, 2017 · 5 comments
Closed
2 of 3 tasks

Emscripten closure compiler breaks WebGL 2 calls #211

mosra opened this issue Jun 18, 2017 · 5 comments
Assignees
Milestone

Comments

@mosra
Copy link
Owner

mosra commented Jun 18, 2017

There are some more cases following those I fixed back in emscripten-core/emscripten#3478 (for example glVertexAttribIPointer()). Temporary solution is to remove --closure 1 from toolchain flags (here).

@mosra mosra added bug labels Jun 18, 2017
@mosra mosra self-assigned this Jun 18, 2017
@mosra
Copy link
Owner Author

mosra commented Mar 25, 2018

I threw away the closure compiler for good, so this is no longer relevant.

💥

@mosra mosra closed this as completed Mar 25, 2018
@mosra mosra added this to the 2018.0b milestone May 1, 2018
@mosra mosra reopened this Nov 1, 2018
@mosra mosra modified the milestones: 2018.04, 2018.1d Nov 1, 2018
@mosra
Copy link
Owner Author

mosra commented Nov 1, 2018

Reopened as the closure compiler can gain us quite nice file size savings. Need to fix the bugs tho.

@mosra
Copy link
Owner Author

mosra commented Nov 22, 2018

Fix that makes all the test working with --closure 1 is submitted in emscripten-core/emscripten#7558.

@mosra
Copy link
Owner Author

mosra commented Dec 29, 2018

Fix released in Emscripten 1.38.21, once the release gets common enough, I'll re-add the flag to all toolchains.

@mosra mosra modified the milestones: 2019.01, 2019.0b Dec 29, 2018
@mosra
Copy link
Owner Author

mosra commented Mar 12, 2019

Since the flag causes significant compilation time increase, it won't get enabled by default. Instead, as of df6b414, there's a new section in the docs listing all extra Emscripten flags with code size / compilation time tradeoffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant