Prevent closure compiler from mangling WebGL 2 API calls #3478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3473 . I just went through all
GLctx.something(...)
calls in the WebGL 2 section, replaced them withGLctx['something'](...)
, tested some of these with--closure 1
and they now work. The only places where I left the original code are inmakeSetValue()
calls like this one:I don't know how the closure compiler handles these (if at all) so they are left untouched. Should I change them too?