-
-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add "transform"
to will-change
#2818
Conversation
@mattgperry just a heads up that this update caused some unexpected breaking changes. The change of the automated Screen.Recording.2024-10-04.at.12.48.35.PM.movI resolved this by overriding with |
@lochie Yeah I can see a config option being useful. But also I am inclined to changing it back to how it was and fixing this Chrome behaviour (only really a problem in Framer) another way. |
@lochie Btw you can also just set |
@mattgperry would be nice to change it back if possible, but I don't know the full scale of this feature so I don't wish to push this in any particular direction, I just wanted to alert of an issue that appeared for me. And just tested Thanks for the response, and as always, love your work 🙏 |
This PR changes the behaviour of auto
will-change
. Rather than add every animating value towill-change
(as preferred) it only enables layerisation by adding"transform"
.This prevents a bug in Chrome that flattens the 3D perspective of an element when
will-change: opacity/filter/clip-path
is added, rather than when one of those values is non-default.