finalized_block_height getter for FinalityView
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add finalized_block_height method for FinalityView, retrieving a previously set block height. This is needed for sanity checks.
andyjsbell
reviewed
Aug 6, 2024
| /// If [`set_finalized_block_height`] has never been called on this | ||
| /// instance, `None` is returned. | ||
| pub fn finalized_block_height(&self) -> Option<u64> { | ||
| let fin_ledger_info = self.finalized_ledger_info.read().unwrap(); |
There was a problem hiding this comment.
That's a lock acquisition. If it returns an error, the lock is poisoned, meaning some other thread has crashed while holding the lock. So it's a condition fatal enough to crash in turn.
There was a problem hiding this comment.
Technically, it's an invariant violation for us not to do this. But, I think maybe we should log and then panic to be a little less opaque.
There was a problem hiding this comment.
IIRC the poisoned lock panic is informative enough. The only "integration" issue is that it is printed on stderr, but perhaps our infrastructure should capture process output for unexpected things like this.
musitdev
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
finalized_block_heightmethod forFinalityView, retrieving a previously set block height.